ui: Improvements for replies and edits #3627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit should be rather self-explanatory.
The motivation behind the second commit is for the use with
Room::restore_composer_draft
. When restoring a draft, but the edited/replied-to item is not available locally, that would result in two requests to the homeserver:Room::event()
to get the content of the edited/replied-to event to be able to display it in the UI.Timeline::{edit/replied_to}_info_from_event_id()
, which makes a request to the homeserver, to be able to callTimeline::edit/send_reply()
to send the event.By exposing the content of the edit/replied-to info, the client needs only to make a single homeserver request with
Timeline::{edit/replied_to}_info_from_event_id()
and can display the edited/replied-to event in the UI with it.